Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From 100 appIds, one consistently returns no result #400

Closed
Giszmo opened this issue Apr 15, 2020 · 14 comments
Closed

From 100 appIds, one consistently returns no result #400

Giszmo opened this issue Apr 15, 2020 · 14 comments

Comments

@Giszmo
Copy link

Giszmo commented Apr 15, 2020

I'm monitoring about 100 apps and it worked great until a week ago or so when one app started returning Error: App not found (404) yet when checking with a browser, the app is there just fine. What could be the reason for this discrepancy?

Edit: Just to confirm, 27 days later this one appId is still the only one not working.

@walrus543
Copy link

walrus543 commented May 8, 2020

I couldn't give a number but I do have issues too for 2 weeks.

I'm stuck on a (random?) package. Example:
image
(Note: this package exists on Google Play)

I have to stop the process. Several downloaded icons have a size of 0 Kb (I can't open them).

@walrus543
Copy link

walrus543 commented May 8, 2020

It happened again with only 8 packages:
image

EDIT: 2 minutes later
image
url: 'https://play.google.com/store/apps/details?id=com.gameloft.android.ANMP.GloftAGHM&hl=en&gl=us' } { Error: Error requesting Google Play:connect ETIMEDOUT 216.58.215.46:443 at /home/arnaud/AndroidAll/Google_Play_Scraper/node_modules/google-play-scraper/lib/utils/request.js:44:19 at <anonymous> at process._tickCallback (internal/process/next_tick.js:188:7) status: undefined }

@yurganov
Copy link
Contributor

shit happens

connect ETIMEDOUT 216.58.215.46:443

that's because of your ISP

@walrus543
Copy link

walrus543 commented May 16, 2020

shit happens

connect ETIMEDOUT 216.58.215.46:443

that's because of your ISP

Same issue with the CLI client of ProtonVPN. I was hoping it could help.

@Giszmo
Copy link
Author

Giszmo commented May 21, 2020

@Primokorn's issue is not mine. My issue is not random at all. My issue is with one app consistently since more than a month and I would appreciate if somebody could check if using google-play-scraper works for them with the appId tech.insense.sensewalet.

@icarcal
Copy link
Collaborator

icarcal commented May 21, 2020

@Giszmo can you provide the language and country that you are using?
By default, this lib uses us as country and en as lang.

The .app method adds two parameters to the link that you provide: hl and gl.

So, if I call the method like this:

gplay.app({
  appId: 'tech.insense.sensewalet'
}).then(console.log);

The real url being called is
https://play.google.com/store/apps/details?id=tech.insense.sensewalet&hl=en&gl=us

Which give me the same error: Error: App not found (404)

BUT, if I call with a different country and lang, I receive the data consistently:

gplay.app({
  lang: 'pt',
  country: 'br',
  appId: 'tech.insense.sensewalet'
}).then(console.log);

My guess is that this is happening 'cause this app is available only in some countries.

@Giszmo
Copy link
Author

Giszmo commented May 22, 2020

I'm in Chile. So they de-published the app for the US market. Makes sense. Many Bitcoin business avoid the US. Thanks for clarifying.

@Giszmo Giszmo closed this as completed May 22, 2020
@walrus543
Copy link

For the records: my issue is solved. I no longer have a timeout. Maybe a temporary issue from my ISP as suggested.
Glad for you @Giszmo :)

@walrus543
Copy link

@icarcal Can I completely remove the language &hl=en&gl=us from the url?
We can access to the url without these 2 parameters: https://play.google.com/store/apps/details?id=tech.insense.sensewalet

Thanks!

@icarcal
Copy link
Collaborator

icarcal commented May 23, 2020

@Primokorn right now there is no way of doing that, and the docs explicitly says what lang and country it defaults to.

I don’t see the point of removing those parameters, since this allow us to know exactly from what country and lang we are getting the app data.

@walrus543
Copy link

walrus543 commented May 23, 2020

@icarcal Because we miss apps which are not available in English. I can't do a "trial and error" language operation for each "app not found".
I only use this tool to download icons so I don't need to know the country.

@facundoolano
Copy link
Owner

That default is intentional and I prefer it to omitting language by default which would produce inconsistent behavior of the same piece of code on different locations/setups.

But I would accept a PR with an option to explicitly tell you want to omit the country, e.g. if you pass {"country": false} then omit the option and use the "machine default". But this would need to be respected in all method calls.

@walrus543
Copy link

@facundoolano Thanks for your understanding. Unfortunately I have no dev skill to suggest a PR.
I work on Android icon packs, I'm more a designer than a developer. Thanks anyway.

@icarcal
Copy link
Collaborator

icarcal commented May 23, 2020

@Primokorn @facundoolano I’ll move this discussion to another issue, as a suggested feature so we can have a better history on this, ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants