Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of EDASM sources #14

Closed
fadden opened this issue Mar 7, 2016 · 2 comments
Closed

Improve handling of EDASM sources #14

fadden opened this issue Mar 7, 2016 · 2 comments
Labels
enhancement

Comments

@fadden
Copy link
Owner

fadden commented Mar 7, 2016

EDASM source files are currently just displayed as formatted text. It'd look a bit better if the fields were tabbed out.

There appears to be a bug in the file viewer as well: if you view an EDASM source (ProDOS type TXT, filename.S) and manually select "Merlin Assembler", the viewer switches to "(file is empty)" and disables the view controls.

Examples can currently be found here: https://github.com/markpmlim/EdAsm
fadden added a commit that referenced this issue Sep 22, 2017
@fadden
Fix file viewer glitch with empty output
549342b 
The file viewer was seeing zero-length formatted output and assuming
that it was the result of zero-length input.  This is a problem
because the code disables the format options when there's nothing to
format.  This resulted in the strange behavior noted in issue #14.

Now the "is source empty" value is passed explicitly, and we display
a different message when the formatter fails.
@fadden
Copy link
Owner Author

fadden commented Sep 23, 2017

Bug that disabled view controls has been fixed.

@fadden fadden removed the bug label Sep 23, 2017
@fadden
Copy link
Owner Author

fadden commented Nov 23, 2023

This seems to work better in CiderPress II.

@fadden fadden closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fadden