This repository has been archived by the owner on May 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 7.0.0 of primus just got published.
The version 7.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of primus.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
Server sent pingsIn this release we have reversed the direction of ping/pong messages. Pings are now sent from server to client to work around issues generated by throttled timers on modern browsers1.
The following diagram should give you an idea of how the new heartbeat system works.
As you might expect there are some breaking changes.
latency
attribute on the client is gone.timeout
has been replaced with a new option calledpingInterval
.ping
andpong
options have been replaced with a new option calledpingTimeout
.A special thanks goes to @STRML who assisted us in making this release possible.
1: http://blog.strml.net/2017/01/chrome-56-now-aggressively-throttles.html
Commits
The new version differs by 17 commits .
30d4a46
[dist] 7.0.0
a11aaeb
[minor] Move heartbeat into Spark so it can be overridden (#562)
cfb211b
[minor] Treat protocol-level pings as valid pongs
62b5df3
[major] Use new option names
3ac09f9
[major] Reverse the direction of ping/pong messages
52eb0f7
chore(package): update uws to version 0.14.0 (#563)
75da37e
[test] Enable some disabled tests
8de2f8d
chore(package): update querystringify to version 1.0.0 (#560)
a1d1b29
[minor] Rebuild the Engine.IO client -- version 2.1.0
6edbcb4
chore(package): update engine.io to version 2.1.0 (#559)
fd52a51
chore(package): update engine.io-client to version 2.1.0 (#558)
7d03277
chore(package): update request to version 2.81.0 (#557)
9c1c52f
[doc] Fix indentation in code snippets (#556)
86de3d6
chore(package): update request to version 2.80.0 (#555)
01c8a09
chore(package): update ws to version 2.2.0 (#554)
There are 17 commits in total. See the full diff.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 馃尨