Support Result as class to enable access to full property list #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The last option is to return the response as a `Result` class. This allows access to the full set of properties returned from the feed. | ||
|
|
||
| ```php | ||
| $result = (new Exchange())->symbols(Currency::USD, Currency::GBP)->getAsObject(); |
There was a problem hiding this comment.
This should be getResult(), right?
There was a problem hiding this comment.
Ah yes, so it should
There was a problem hiding this comment.
I've fixed this upstream, but this is merged now. Shall I open a new PR?
There was a problem hiding this comment.
Opened #4 to include fixing that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the Fixer.io result may have been generated on a date earlier than what you ask for. For example: https://api.fixer.io/2016-07-10
This change creates a
Resultobject out of the whole feed, so that the date can be compared to what was expected, and then the rates read.This is a new method, so everything is backwards compatible with what existed before.