Fixed bug where certain UCS-2 codepoints were not decoded correctly #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fador
added a commit
that referenced
this pull request
Apr 4, 2012
Fixed bug where certain UCS-2 codepoints were not decoded correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the usage of certain characters in the chat, e.g. "ö", and it happened because there was a
charthat needed to be anunsigned char.ö is the Unicode codepoint 246. In UCS-2, it is represented by the sequence
0x00 0xf6(big endian). Without the change, the second byte is treated as a negative number, which gets really big when casted tounsigned int. Sounds fun, but I can't really explain it. :D