Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Differentiate traits and trait implementations #102

Merged
merged 6 commits into from
Jul 1, 2022
Merged

Core: Differentiate traits and trait implementations #102

merged 6 commits into from
Jul 1, 2022

Conversation

IoannisP-ITENG
Copy link
Contributor

@IoannisP-ITENG IoannisP-ITENG commented Jul 1, 2022 •
edited
Loading

Core: Differentiate traits and trait implementations

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #96

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@IoannisP-ITENG IoannisP-ITENG added ✨ goal: improvement Improvement to an existing feature 🟧 priority: high Stalls work on the project or its dependents 💻 area: core Concerns the faebryk core labels Jul 1, 2022
@IoannisP-ITENG IoannisP-ITENG self-assigned this Jul 1, 2022
@IoannisP-ITENG IoannisP-ITENG force-pushed the feature/differentiate_traits_from_impl branch 2 times, most recently from 127ed5c to 2876269 Compare July 1, 2022 09:00
@IoannisP-ITENG IoannisP-ITENG force-pushed the feature/differentiate_traits_from_impl branch from 5b224d5 to 9f66366 Compare July 1, 2022 13:36
@IoannisP-ITENG IoannisP-ITENG marked this pull request as ready for review July 1, 2022 15:35
@IoannisP-ITENG IoannisP-ITENG merged commit fc649a2 into main Jul 1, 2022
@IoannisP-ITENG IoannisP-ITENG deleted the feature/differentiate_traits_from_impl branch July 1, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IoannisP-ITENG IoannisP-ITENG

Labels
💻 area: core Concerns the faebryk core ✨ goal: improvement Improvement to an existing feature 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core: Broken trait system
1 participant
@IoannisP-ITENG