Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Add components used by eurorack example #106

Conversation

ruben-iteng
Copy link
Collaborator

Components: Add components used by eurorack example

Description

Add potentiometer
Add PJ398SM mono 3.5mm jack
Add generic transistor
Fix Capacitor traits & interface setup

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

Add potentiometer
Add PJ398SM mono 3.5mm jack
Add generic transistor
Fix Capacitor traits & interface setup
@ruben-iteng ruben-iteng added ⭐ goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed 🗂 area: library Concerns the faebryk library labels Jul 1, 2022
@ruben-iteng ruben-iteng self-assigned this Jul 1, 2022
@IoannisP-ITENG IoannisP-ITENG merged commit afcf021 into faebryk:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗂 area: library Concerns the faebryk library ⭐ goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants