Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Core: Fix assert syntax #108

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

IoannisP-ITENG
Copy link
Contributor

@IoannisP-ITENG IoannisP-ITENG commented Jul 1, 2022

Bugfix: Core: Fix assert syntax

Description

Fix assert always being true.

Fixes # (issue)

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@IoannisP-ITENG IoannisP-ITENG added 🛠 goal: bug fix Something isn't working 🟩 priority: low Low priority and doesn't need to be rushed 💻 area: core Concerns the faebryk core labels Jul 1, 2022
@IoannisP-ITENG IoannisP-ITENG merged commit a1cc883 into main Jul 1, 2022
@IoannisP-ITENG IoannisP-ITENG deleted the bugfix/core_assert_syntax branch July 1, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 area: core Concerns the faebryk core 🛠 goal: bug fix Something isn't working 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant