Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: Fix missing dependencies #119

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

NoR8quoh1r
Copy link
Contributor

@NoR8quoh1r NoR8quoh1r commented Sep 9, 2022

Packaging: Fix missing dependencies

Description

Move packaging information to pyproject.toml and add the missing dependencies.
Move samples to examples, so setuptools can autodetect the package directory structure.

Fixes # (#118)

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

Move packaging information to pyproject.toml and add the missing
dependencies.
Move samples to examples, so setuptools can autodetect the package
directory structure.
@ruben-iteng ruben-iteng added 🛠 goal: bug fix Something isn't working 🟨 priority: medium Not blocking but should be fixed soon 🤖 area: ci/cd Concerns CI/CD labels Sep 23, 2022
@IoannisP-ITENG IoannisP-ITENG merged commit 1c87539 into faebryk:main Oct 7, 2022
@NoR8quoh1r NoR8quoh1r deleted the fix/package-deps/wip branch October 14, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 area: ci/cd Concerns CI/CD 🛠 goal: bug fix Something isn't working 🟨 priority: medium Not blocking but should be fixed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants