Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Readme: Fix example instructions #144

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Bugfix: Readme: Fix example instructions #144

merged 1 commit into from
Oct 28, 2022

Conversation

IoannisP-ITENG
Copy link
Contributor

@IoannisP-ITENG IoannisP-ITENG commented Oct 28, 2022 •
edited
Loading

Bugfix: Readme: Fix example instructions

Description

Rename from sample to example.
Remove tail command.

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@IoannisP-ITENG
Bugfix: Readme: Fix example instructions
9a2227a 
Rename from sample to example.
Remove tail command.
@IoannisP-ITENG IoannisP-ITENG added 🛠 goal: bug fix Something isn't working 📄 area: documentation Improvements or additions to documentation 🟨 priority: medium Not blocking but should be fixed soon labels Oct 28, 2022
ruben-iteng
ruben-iteng approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@ruben-iteng ruben-iteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IoannisP-ITENG IoannisP-ITENG merged commit 6e245c5 into main Oct 28, 2022
@IoannisP-ITENG IoannisP-ITENG deleted the bugfix/fix_readme_examples branch May 21, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-iteng ruben-iteng ruben-iteng approved these changes

Assignees
No one assigned
Labels
📄 area: documentation Improvements or additions to documentation 🛠 goal: bug fix Something isn't working 🟨 priority: medium Not blocking but should be fixed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IoannisP-ITENG @ruben-iteng