Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Tools: Fix aliased pins in converter #145

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

IoannisP-ITENG
Copy link
Contributor

@IoannisP-ITENG IoannisP-ITENG commented Oct 28, 2022

Bugfix: Tools: Fix aliased pins in converter

Description

  • Add heuristic for pin naming: pin_no string
  • Remove aliasing
  • Remove hiding
  • Group same-name pins into list

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

- Add heuristic for pin naming: pin_no string
- Remove aliasing
- Remove hiding
- Group same-name pins into list
@IoannisP-ITENG IoannisP-ITENG added 🛠 goal: bug fix Something isn't working ⛏️ area: tools Development tools labels Oct 28, 2022
@IoannisP-ITENG IoannisP-ITENG merged commit e6e9dce into main Oct 28, 2022
@IoannisP-ITENG IoannisP-ITENG deleted the bugfix/aliased_pins_lib_converter branch May 21, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛏️ area: tools Development tools 🛠 goal: bug fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant