Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples; Add minimal led #170

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

IoannisP-ITENG
Copy link
Contributor

@IoannisP-ITENG IoannisP-ITENG commented May 23, 2024

Examples: Add minimal led; Library: Add ANY

Examples: Add some extra buildutils
lcsc: Improve paths
core: Make operations repr more readable
Library: Add Battery & Buttoncell
Picker: Improve recursive picking order determination
Library: Add ANY Parameter and update Operation resolution & picker

Description

Add a very simple, minimal code example to demonstrate faebryks power in a gif.

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

Examples: Add some extra buildutils
lcsc: Improve paths
core: Make operations repr more readable
Library: Add Battery & Buttoncell
Picker: Improve recursive picking order determination
@IoannisP-ITENG
Copy link
Contributor Author

IoannisP-ITENG commented May 23, 2024

Somethings going wrong with the Operation param resolution in the example for the current limiting resistor.

PickError: Could not find part for module=<*|App.led|PoweredLED.current_limiting_resistor|Resistor> with params:
 {   'resistance': <*|Operation>[Parameter.__truediv__.<locals>.<lambda>](
  <*|Operation>[Parameter.__sub__.<locals>.<lambda>](
    <*|App.led|PoweredLED.power|ElectricPower.voltage|TBD>
    <*|Constant>(3.7)
  )
  <*|Operation>[Parameter.op.<locals>._is_pair.<locals>.<lambda>](
    <*|Constant>(0.1)
    <*|Operation>[Parameter.__truediv__.<locals>.<lambda>](
      <*|App.led|PoweredLED.led|LED.brightness|TBD>
      <*|Constant>(0.285)
    )
  )
)}

@IoannisP-ITENG IoannisP-ITENG marked this pull request as ready for review May 28, 2024 16:02
@IoannisP-ITENG IoannisP-ITENG merged commit e5f2fd6 into main May 28, 2024
@IoannisP-ITENG IoannisP-ITENG deleted the feature/examples_minimal_led branch May 28, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant