-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part: Add PartIdentifier (mfr, p/n, datasheet) #172
Conversation
Adds an optional PartIdentifier to a Part, which describes the partnumber, manufacturer, and datasheet. This could be used for BOM exports. Fixes faebryk#165
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to be able to pass through info from the pickeroption to the module descriptive_properties!
There is already (nearly) a way to do that with lower footprint.
You can use the info dict in pickeroption and pass that instead of the part because it contains the part anyway. This is useful for future additions too to avoid breaking the supplier API. The supplier can that just transparently decide to ad the properties to the module.
See the comments for more detail.
0d5b39b
to
b16e0a5
Compare
Remove PartIdentifier and merge functionality into Part.info. Add DescriptiveProperties for standardizing the mfr, datasheet, and p/n string names.
b16e0a5
to
f89b608
Compare
Sets PickerOption.info to accept DescriptiveProperties explicitly
Part: Add PartIdentifier (mfr, p/n, datasheet)
Description
Adds an optional PartIdentifier to a Part, which describes the partnumber, manufacturer, and datasheet.
This could be used for BOM exports.
Fixes #165
Checklist
Please read and execute the following:
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct: