Add utilities for BOM generation #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add util function to round float to least significant decimal Add util function to print a Parameter as a unit with tolerance (range center +- delta) Add has_simple_value_representation_based_on_params trait, which is the same as as_simple_value_representation_based_on_param but with mulitple parameters and support for ranges Add classmethods for Range to create a Range from a lower/upper bound or from center. Add rated_power parameter to Resistor and accompanying set functions
IoannisP-ITENG
requested changes
May 29, 2024
src/faebryk/library/has_simple_value_representation_based_on_params.py
Outdated
Show resolved
Hide resolved
Move round_to_least_significant_decimal to util.py/round_str Remove duplicate is_type_set_subclasses Remove redundant braces Merge string concat into one f-string
Just use type hinting of Sequence[Constant | Range], typevar is not necessary.
IoannisP-ITENG
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utilities for BOM generation
Description
Add util function to round float to least significant decimal Add util function to print a Parameter as a unit with tolerance (range center +- delta)
Add has_simple_value_representation_based_on_params trait, which is the same as as_simple_value_representation_based_on_param but with mulitple parameters and support for ranges
Add classmethods for Range to create a Range from a lower/upper bound or from center.
Add rated_power parameter to Resistor and accompanying set functions
Add util function to round float to least significant decimal Add util function to print a Parameter as a unit with tolerance (range center +- delta)
Add has_simple_value_representation_based_on_params trait, which is the same as as_simple_value_representation_based_on_param but with mulitple parameters and support for ranges
Add classmethods for Range to create a Range from a lower/upper bound or from center.
Add rated_power parameter to Resistor and accompanying set functions
Checklist
Please read and execute the following:
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct: