Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib: accept all params for simple_value_rep #182

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

JasperZP
Copy link
Contributor

@JasperZP JasperZP commented Jun 13, 2024

Lib: accept all params for simple_value_rep

Description

Let has_simple_value_representation_based_on_params, as_unit, and as_unit_with_tolerance accept any parameter.

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Ruff to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

Let has_simple_value_representation_based_on_params, as_unit, and
as_unit_with_tolerance accept any parameter.
@IoannisP-ITENG IoannisP-ITENG merged commit 979ad97 into faebryk:main Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants