Netlist: Refactor #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoR8quoh1r
changed the title
|
Maybe pins should not be ints? |
Instead of using dicts and tuples introduce a few data classes with equivalent fields. These fields must exist, so nothing is lost by not using dicts/tuples. The class definitions also serve to document the structure of the netlist.
Move hashable vertex helper class into _make_graph, also improve readability a bit by renaming variables, etc. Get rid of the vertex helper in render_graph, which is done by connecting the pins of a component via new node, instead of creating edges between pins.
NoR8quoh1r
force-pushed
the
cleanup/netlist/0/wip
branch
from
484a6b4
to
5cabd62
Compare
IoannisP-ITENG
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using dicts and tuples introduce a few data classes with
equivalent fields. These fields must exists, so nothing is lost
by not using dicts/tuples.
The class definitions also serve to document the structure of the
netlist.