Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Add code owners #30

Merged

Conversation

ruben-iteng
Copy link
Collaborator

Description

Add basic code owners file for automatically assigning and notifying maintainers.

PR type

New feature (non-breaking change which adds functionality)

Linked Issue

#17

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct

  • I agree to follow this project's Code of Conduct

@ruben-iteng ruben-iteng added the 📄 area: documentation Improvements or additions to documentation label Jan 7, 2022
Copy link
Contributor

@IoannisP-ITENG IoannisP-ITENG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is trailing space before the dot

@ruben-iteng ruben-iteng linked an issue Jan 7, 2022 that may be closed by this pull request
@IoannisP-ITENG
Copy link
Contributor

Thanks! Looks good.

@IoannisP-ITENG IoannisP-ITENG merged commit 5c769d4 into faebryk:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 area: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta: Add codeowners
2 participants