Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample: Add explanation to current examples #65

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Sample: Add explanation to current examples #65

merged 1 commit into from
Mar 4, 2022

Conversation

IoannisP-ITENG
Copy link
Contributor

@IoannisP-ITENG IoannisP-ITENG commented Mar 4, 2022 •
edited
Loading

Sample: Add explanation to current examples

Description

Add top-of-file comment to the current samples.

Fixes #64

PR type

New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@IoannisP-ITENG
Sample: Add explanation to current examples
d71b9be 
Add top-of-file comment to the current samples.
@IoannisP-ITENG IoannisP-ITENG added ⭐ goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents 🧐 area: samples Concerns code samples labels Mar 4, 2022
ruben-iteng
ruben-iteng approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@ruben-iteng ruben-iteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear short explanation.

@IoannisP-ITENG IoannisP-ITENG merged commit eb63d9f into main Mar 4, 2022
@ruben-iteng ruben-iteng added this to the Release 1.0.0 milestone Mar 4, 2022
@IoannisP-ITENG IoannisP-ITENG deleted the feature/samples_add_explanations branch June 24, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-iteng ruben-iteng ruben-iteng approved these changes

Assignees
No one assigned
Labels
🧐 area: samples Concerns code samples ⭐ goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging this pull request may close these issues.

Add explanation to current samples
2 participants
@IoannisP-ITENG @ruben-iteng