Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library: Add QFN footprint #77

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Library: Add QFN footprint #77

merged 1 commit into from
Apr 1, 2022

Conversation

IoannisP-ITENG
Copy link
Contributor

@IoannisP-ITENG IoannisP-ITENG commented Apr 1, 2022 •
edited
Loading

Add QFN footprint to library.

Description

Adds a generic QFN footprint to library.

Fixes <no issue>

PR type

  • New feature (non-breaking change which adds functionality)

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@ruben-iteng ruben-iteng self-requested a review April 1, 2022 08:30
@ruben-iteng ruben-iteng added ⭐ goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed 🗂 area: library Concerns the faebryk library labels Apr 1, 2022
ruben-iteng
ruben-iteng requested changes Apr 1, 2022
View reviewed changes
faebryk/library/library/footprints.py Outdated Show resolved Hide resolved
faebryk/library/library/footprints.py Outdated Show resolved Hide resolved
@IoannisP-ITENG
Library: Add QFN footprint
2e70f94 
Add QFN footprint to library.
Add footprint test class.
Add QFN footprint tests.
ruben-iteng
ruben-iteng approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@ruben-iteng ruben-iteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way better 😉

@IoannisP-ITENG IoannisP-ITENG merged commit 06b3ff6 into main Apr 1, 2022
@IoannisP-ITENG IoannisP-ITENG deleted the feature/lib_footprint_qfn_add branch June 24, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-iteng ruben-iteng ruben-iteng approved these changes

Assignees
No one assigned
Labels
🗂 area: library Concerns the faebryk library ⭐ goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IoannisP-ITENG @ruben-iteng