Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library: Add Ranged parameter #91

Merged

Conversation

ruben-iteng
Copy link
Collaborator

Description

Add a ranged parameter (min/max)

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

Add a ranged parameter (min/max)
@ruben-iteng ruben-iteng added ⭐ goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed 🗂 area: library Concerns the faebryk library labels Jun 3, 2022
@ruben-iteng ruben-iteng self-assigned this Jun 3, 2022
Copy link
Contributor

@IoannisP-ITENG IoannisP-ITENG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@IoannisP-ITENG IoannisP-ITENG merged commit 58810da into faebryk:main Jun 3, 2022
@ruben-iteng ruben-iteng deleted the feature/add_range_parameter branch June 24, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗂 area: library Concerns the faebryk library ⭐ goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants