Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph: Handle pin not in map explicitly #94

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

IoannisP-ITENG
Copy link
Contributor

Throw faebryk exception if pin of target not in target pinmap.

Graph: Handle pin not in map explicitly

Description

Cleaner exception for pinmap problems while building graph.

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

Throw faebryk exception if pin of target not in target pinmap.
@IoannisP-ITENG IoannisP-ITENG added ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 💻 area: core Concerns the faebryk core labels Jun 24, 2022
@IoannisP-ITENG IoannisP-ITENG merged commit 14bae55 into main Jun 24, 2022
@IoannisP-ITENG IoannisP-ITENG deleted the feature/cleaner_graph_pinmap_exception branch June 24, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 area: core Concerns the faebryk core ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant