Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision log interface #2

Closed
wants to merge 2 commits into from
Closed

Conversation

dawehner
Copy link
Collaborator

Just like node provides revision logs it would be nice for entity types
to provide such a feature.

@bojanz
Copy link
Collaborator

bojanz commented Oct 26, 2015

Such an interface should have a matching trait?

Don't all revisionable entities have to have a revision log? In which case it might make more sense to have a bigger interface with getters/setters for revision log, revision author, revision creation time?

@dawehner
Copy link
Collaborator Author

Don't all revisionable entities have to have a revision log? In which case it might make more sense to have a bigger interface with getters/setters for revision log, revision author, revision creation time?

I mean I don't care that much at all. The usecase I currently have does not need revision log, as its never something actually created by users in the first place

@bojanz
Copy link
Collaborator

bojanz commented Oct 26, 2015

Quoting Dick on IRC:
"I see, yeah that makes sense. But I think there will be the same arguments about both revision author, and revision created from other use cases and angels. e.g. someone will want revision log, but not doesn't need to track revision author
but in all honesty it's not too important to me. But fago was just very clear that he wanted the enhancers to be quite/very opinionated... I guess so that we don't end up with another 1000 interfaces in the Entity API"

So he's in favor of having one interface for all three.

@Berdir
Copy link
Collaborator

Berdir commented Oct 26, 2015

+1. We can just document on the interface that those methods can return NULL if they don't have that information.

@dawehner
Copy link
Collaborator Author

Alright consensus yeah! See us in #5

@dawehner dawehner closed this Oct 27, 2015
dawehner added a commit to dawehner/entity that referenced this pull request Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants