Port Path Alias Delete to D8 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function execute() { | ||
| $path = $this->getContextValue('path'); | ||
| $alias = $this->aliasManager->getAliasByPath($path); |
There was a problem hiding this comment.
Why do you need to load the alias? You can just pass the path as condition to the delete() method? That should delete all aliases for that path?
|
Why do you need to load the alias? - good question, it's my current blurred understanding of the changes from procedural to OO. It'll get there, I'm old, it takes longer to sink in these days :D Have removed references to aliasmanager and squashed the commit. |
|
|
||
| use Drupal\Core\Plugin\Context\ContextDefinition; | ||
| use Drupal\rules\Plugin\Action\PathAliasDelete; | ||
| use Drupal\rules\Tests\RulesUnitTestBase; |
There was a problem hiding this comment.
That file has been moved, that's why the tests are failing. Make sure to run the phunit tests locally.
|
Oops, I'd realised they'd been fixed but I thought for a moment my local 8.x-3.x branch was just out-of-date but wasn't. Fixed. |
|
Right, think I've got it :D |
klausi
added a commit
that referenced
this pull request
Sep 16, 2014
…338595 Port Path Alias Delete to D8
| * | ||
| * @Action( | ||
| * id = "rules_path_aliases_delete", | ||
| * label = @Translation("Delete alias for a path"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an initial stab at the "Delete alias for path". Unsure currently how to deal with multiple values, i.e. if there's more than one alias for the path, couldn't see a relevant function in the AliasManager for this.