Issue #2593139: Add configuration_access annotation key for plugins. #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torenware
force-pushed
the
configure-permission-2593139
branch
from
9f9e4cb
to
5fccaa9
Compare
| @@ -11,7 +11,13 @@ | |||
| use \Drupal\Core\Plugin\Discovery\AnnotatedClassDiscovery as CoreAnnotatedClassDiscovery; | |||
|
|
|||
| /** | |||
| * Extends the annotation class discovery for usage with Rules context. | |||
There was a problem hiding this comment.
This was right actually, it's more than just annotations - let's leave the old comment.
torenware
force-pushed
the
configure-permission-2593139
branch
2 times, most recently
from
b44783d
to
0ee695b
Compare
| @@ -51,6 +51,14 @@ class RulesAction extends Plugin { | |||
| public $category; | |||
|
|
|||
| /** | |||
| * The permission required to access the configuration UI for this plugin. | |||
| * | |||
| * @var string | |||
There was a problem hiding this comment.
shouldn't this be string[]? EDIT: not sure about this, so we can leave it as a single permission right now.
torenware
force-pushed
the
configure-permission-2593139
branch
3 times, most recently
from
a319416
to
81307a0
Compare
| $this->assertTrue($plugin->checkConfigurationAccess(), "User with permission has configuration access."); | ||
|
|
||
| $object_result = $plugin->checkConfigurationAccess($user_with_perm->reveal(), TRUE); | ||
| $this->assertTrue($object_result instanceof AccessResult, "an AccessResult object is returned if an object is requested."); |
There was a problem hiding this comment.
we should assert here that $object_result->isAllowed() is true, no need to check the class.
torenware
force-pushed
the
configure-permission-2593139
branch
from
81307a0
to
72d1297
Compare
torenware
force-pushed
the
configure-permission-2593139
branch
from
72d1297
to
02ab4d0
Compare
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal Issue https://www.drupal.org/node/2593139.