#2269575 - PathHasAlias condition implementation. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| namespace Drupal\rules\Plugin\Condition; | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove the extra line break.
|
This is now almost completely copied from PathAliasExists condition. Still don't know why tests are failing... |
|
I can a look if you don't mind. |
|
Sure. Go ahead. 2014-06-05 10:08 GMT+02:00 fubhy notifications@github.com:
|
|
Continued in #35 The reason for the failures here: There is something called AliasWhitelist in Drupal core that ensures that you cannot create/lookup path aliases for paths that don't actually exist. Hence you need to use a path like 'user' (which exists once you enable the system module which inheretly enables the user module). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take at implementing the PathHasAlias condition. Previously opened as #7.