Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listcountis 2281085 #54

Closed
wants to merge 10 commits into from
Closed

Listcountis 2281085 #54

wants to merge 10 commits into from

Conversation

jesseday
Copy link

@jesseday jesseday commented Jun 6, 2014

see: https://drupal.org/node/2281085
Port "List count comparison (list_count_is)" condition to 8.x

Creates ListCountIs plugin and ListCountIsTest class.

Still need to be able to set default_value, options_list and restriction for the operator parameter.

return count($list) > $value;
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing carriage return at end of file.

@fubhy
Copy link
Collaborator

fubhy commented Jun 11, 2014

Hey! Are you still working on this? If not, I can take over if you want :)

@jesseday
Copy link
Author

Hey, I'd love to keep working on it, but I'm swamped with catch up work after drupal con. If you have time to take it over, that would probably be faster than waiting for me at the moment.

@paranojik
Copy link
Contributor

Hey @fubhy, @jesseday ... can I take a look?

@klausi
Copy link
Collaborator

klausi commented Jun 26, 2014

@paranojik sure, just go ahead!

@paranojik
Copy link
Contributor

New pull request here: #73.

@fubhy fubhy closed this Jun 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants