Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with the observer pattern #398

Closed
LuMiSxh opened this issue Aug 5, 2022 · 0 comments
Closed

Issue with the observer pattern #398

LuMiSxh opened this issue Aug 5, 2022 · 0 comments
Labels
question

Comments

@LuMiSxh
Copy link

LuMiSxh commented Aug 5, 2022

Hey, I'm currently working on expanding the type hints and noticed a mistake. In patterns/behavioral/observer.py, the classes HexViewer and DecimalViewer are supposed to innherit the Observer-class, but dont.
Should I fix it and open a pr?
@LuMiSxh LuMiSxh mentioned this issue Aug 5, 2022
Closed
@faif faif added the question label Aug 16, 2022
@faif faif closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing issues
2 participants
@faif @LuMiSxh