add sinusoid tone generation #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I just have a couple comments/suggestions. It looks like a linter hasn't been run on the code; there are no indentions. Please run this through the go linter and update the PR. |
dusk125
requested changes
Aug 31, 2021
dusk125
approved these changes
Aug 31, 2021
dusk125
requested changes
Aug 31, 2021
examples/tone-player/main.go
Outdated
| "strconv" | ||
| ) | ||
| func main() { | ||
| f, _ := strconv.Atoi(os.Args[1]) |
There was a problem hiding this comment.
Please add a usage message if the argument isn't provided.
There was a problem hiding this comment.
And if it's provided and it's not an integer.
dusk125
approved these changes
Aug 31, 2021
|
Thanks for the changes, looks good! |
MarkKremer
pushed a commit
to MarkKremer/beep
that referenced
this pull request
Apr 6, 2024
Fix flac.Decode handling of io.EOF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #126