[ Issue #21 ] Adding Examples #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiface
requested changes
Jun 12, 2018
examples/mp3-playing.go
Outdated
| ) | ||
|
|
||
| func main() { | ||
| // Open first Sample File |
examples/mp3-playing.go
Outdated
| // Open first Sample File | ||
| f, err := os.Open("sample1.mp3") | ||
|
|
||
| // Check for Errors when opening the file |
examples/mp3-playing.go
Outdated
| // Channel, which will signal the end of the playback. | ||
| playing := make(chan struct{}) | ||
|
|
||
| // Now we Play our Stream on the Speaker |
|
Hi, thanks a lot for contributing this example! Other example suggestions would be:
|
|
Okay, i will correct the comments and add some more Examples. Maybe a specified folder for an example, so people can easily go build. |
|
Updated the Pull Reques and added a folder structure for the Examples |
|
Great! Thanks a lot for this. |
|
Thanks for merging, im now working on the ctrl example and effects example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some Examples
As requested here's the Pull Request for Issue #21 . Its just basic playing and i tried to keep the sample mp3 as small as possible (6,2kib) . Suggestions for more Examples ?