Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the -no auth attempts- from the triggers because of lots of FP #600

Merged
merged 4 commits into from Jan 31, 2014

Conversation

aseques
Copy link
Contributor

@aseques aseques commented Jan 28, 2014

According to dovecot's wiki http://wiki2.dovecot.org/WhyDoesItNotWork

Aborted login (no auth attempts) means that the client isn't even attempting to log in. Most likely you have disable_plaintext_auth=yes (default) and the client isn't configured to use SSL/TLS (or you've also set ssl=no).

Looking on our logs, I found plenty of legitimate clients facing this error, and found on the internet reports for many mail clients (thunderbird, kmail, outlook, ..), just have a look at "no auth attempts" at google. Most of the times is mail client fault

Hence I disabled this from the regexp and adjusted both the sample logs and the code.

@grooverdan
Copy link
Contributor

Actually grouping the test cases you've removed and changing the "match" to "false" in failJSON would be good so we don't accidentally cover this again.

I'm ok with this change. Wouldn't mind someone else confirming it.

@kwirk
Copy link
Contributor

kwirk commented Jan 28, 2014

👍 I've noticed that when connections drop from bad mobile phone signal this can trip...

… to avoid accidentally reenabling them in the future
… to avoid accidentally reenabling them in the future
@grooverdan
Copy link
Contributor

thank you. I've merged this in #601 with additional samples from the mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants