Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration editor #365

Merged
merged 14 commits into from
Feb 27, 2022
Merged

Configuration editor #365

merged 14 commits into from
Feb 27, 2022

Conversation

hramberger
Copy link
Member

@hramberger hramberger commented Jan 23, 2022 •
edited by bjoernboehnke
Loading

Provides a configuration editor in which all configurations can be updated in a live view. This configuration editor also allows the export of the current configuration to the users clipboard.

Closes #49
Closes #157

PR Checklist

  • Wrote a good commit message & description according to conventional commits [see guide below].
  • The PR is linked to an issue.
  • Added/Updated unit tests.
  • All unit tests are passing.
  • Used the same coding conventions as the rest of the project.
  • The PR relates to only one subject with a clear title
  • The PR description uses grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits or rebase branch.

Other Information

Conventional commits

@hramberger hramberger marked this pull request as draft January 23, 2022 15:09
@hramberger hramberger self-assigned this Feb 27, 2022
@github-actions github-actions bot added demo Changes related to the demo page documentation Improvements or additions to documentation lib Changes to the Darkbox library itself test Everything related to automatic tests labels Feb 27, 2022
@bjoernboehnke bjoernboehnke marked this pull request as ready for review February 27, 2022 20:51
@bjoernboehnke bjoernboehnke merged commit 875b042 into main Feb 27, 2022
@bjoernboehnke bjoernboehnke deleted the feature/configuration-editor branch February 27, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernboehnke bjoernboehnke Awaiting requested review from bjoernboehnke

Assignees

@hramberger hramberger

Labels
demo Changes related to the demo page documentation Improvements or additions to documentation lib Changes to the Darkbox library itself test Everything related to automatic tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the advanced configurtion example Add configuration editor
2 participants
@hramberger @bjoernboehnke