retrypolicy: fix '-1' logic for WithMaxAttempts => maxRetries

[srenatus]

Before, setting WithMaxAttempts(-1) led to maxRetries = -2, and this check would always trigger:

failsafe-go/retrypolicy/retryexecutor.go

Line 82 in d6a1efd

maxRetriesExceeded := rpe.config.maxRetries != -1 && rpe.failedAttempts > rpe.config.maxRetries

As a result, no retry attempts would be made.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 52.52%. Comparing base (3be8274) to head (d7f5779).

Files	Patch %	Lines
retrypolicy/retry.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   52.67%   52.52%   -0.15%     
==========================================
  Files          19       19              
  Lines        1403     1407       +4     
==========================================
  Hits          739      739              
- Misses        648      652       +4     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jhalterman]

Apologies for the conflict. If you can rebase c5bf7dc again off of main, I can merge.

[srenatus]

Ok it's fixed. I'm a little surprised that you saw a reason to force-push the main branch, to be frank 😅

[jhalterman]

Yea, fair point. Once a repo starts to get collaborators, it's better to just revert a commit 😄

Thanks for the PR!

[jhalterman]

This was released in 0.6.0 along with http support.