New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
withExecutor causes Failsafe not to retry on exceptions in some cases #311
Comments
Aside: The overloading introduced by #221 isn't helping here. If you replace the line:
with
the test passes as expected. Would it be terrible to use a longer name for the wrapping case, e.g., |
Thanks for filing this. I agree @Tembrel, a more explicit name wouldn't be bad. Thinking of other options though, since the intent here is to provide an Edit: A similar check for |
How about adding those Explicit names are nice for those who read others' code; they can skip that momentary confusion that occurs when encountering a line with no type information: .with(CONNECT_POOL) You can argue that .withExecutorService(CONNECT_POOL) Maybe an explicit name like |
3.0.2 is released with a fix for this regression. |
Amazing, thank you! |
Hey, thank you for this great library! I've got an issue to report however.
If you comment out
.with(executor)
the test case will work. When the case fails the method is run fromFunctions.java#withExecutor(ContextualSupplier<R, T> supplier, Executor executor)
which callshandleExecutableThrowable
which just throws the exception again. With the line commented out it uses a different code path that actually handles the exception.The text was updated successfully, but these errors were encountered: