Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Majordomo Broker V0.1 PoC #273

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Majordomo Broker V0.1 PoC #273

merged 2 commits into from
Oct 9, 2020

Conversation

RalphSteinhagen
Copy link
Member

Majordomo Broker V0.1 proof-of-concept to be developed into an independent microservice middle-ware

This is the reference implementation to compare future iterations and upgrades against.

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #273 into master will decrease coverage by 4.21%.
The diff coverage is 17.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #273      +/-   ##
============================================
- Coverage     47.90%   43.68%   -4.22%     
- Complexity     5624     5869     +245     
============================================
  Files           341      367      +26     
  Lines         34827    39562    +4735     
  Branches       5699     6346     +647     
============================================
+ Hits          16683    17282     +599     
- Misses        17101    21231    +4130     
- Partials       1043     1049       +6     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/de/gsi/acc/remote/BasicRestRoles.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/de/gsi/acc/remote/RestCommonThreadPool.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...cc/src/main/java/de/gsi/acc/remote/RestServer.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/de/gsi/acc/remote/admin/RestServerAdmin.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/de/gsi/acc/remote/clipboard/Clipboard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/de/gsi/acc/remote/login/LoginController.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...src/main/java/de/gsi/acc/remote/user/RestUser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/de/gsi/acc/remote/user/RestUserHandlerImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/de/gsi/acc/remote/util/CombinedHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ain/java/de/gsi/acc/remote/util/MessageBundle.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5b1ab...e7675f7. Read the comment docs.

wirew0rm
wirew0rm previously approved these changes Oct 9, 2020
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoClientV2.java  3
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/SimpleEchoServiceWorker.java  1
- microservice/src/test/java/de/gsi/microservice/rbac/BasicRbacRole.java  1
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoWorker.java  7
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoClientV1.java  9
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoProtocol.java  22
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/legacy/CmwLightClient.java  6
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/ClientSampleV2.java  7
- microservice/src/test/java/de/gsi/microservice/concepts/RestBehindRouterEvaluation.java  11
- microservice/src/test/java/de/gsi/microservice/utils/SystemProperties.java  4
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/ClientSampleV1.java  6
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoBroker.java  19
- microservice/src/test/java/de/gsi/microservice/utils/WorkerThreadFactory.java  6
- microservice/src/test/java/de/gsi/microservice/rbac/RbacToken.java  5
- microservice/src/test/java/de/gsi/microservice/concepts/BlockingQueueTests.java  5
- microservice/src/test/java/de/gsi/microservice/concepts/PushPullTests.java  5
- microservice/src/test/java/de/gsi/microservice/concepts/RoundTripAndNotifyEvaluation.java  6
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/MajordomoBrokerTests.java  1
         

Clones added
============
- microservice/src/test/java/de/gsi/microservice/concepts/majordomo/legacy/CmwLightClient.java  2
- microservice/src/test/java/de/gsi/microservice/concepts/BlockingQueueTests.java  2
- microservice/src/test/java/de/gsi/microservice/concepts/PushPullTests.java  2
         

See the complete overview on Codacy

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

@RalphSteinhagen RalphSteinhagen merged commit 11a4bd2 into master Oct 9, 2020
@RalphSteinhagen RalphSteinhagen deleted the majordomo_concept branch October 9, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants