fixes memory-leak: WeakHashMap -> SoftHashMap<…TickMark> - based cache #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TickMark> - based cache implementation See following references for details: https://ewirch.github.io/2013/12/weakhashmap-memory-leaks.html https://franke.ms/memoryleak1.wiki N.B. latter author filed this as a bug at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7145759 which was apparently dropped by Oracle devs as supposedly the intended behaviour for a WeakHashMap-based cache.
RalphSteinhagen
force-pushed
the
fixWeakHashMapMemoryLeak
branch
from
17a4ac1
to
ba7f2ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
============================================
+ Coverage 49.78% 49.80% +0.02%
- Complexity 6859 6864 +5
============================================
Files 380 380
Lines 40065 40065
Branches 6420 6420
============================================
+ Hits 19945 19955 +10
+ Misses 18709 18706 -3
+ Partials 1411 1404 -7
Continue to review full report at Codecov.
|
wirew0rm
approved these changes
Oct 30, 2020
RalphSteinhagen
added a commit
that referenced
this pull request
Nov 5, 2020
…TickMark> - based cache implementation (#291) See following references for details: https://ewirch.github.io/2013/12/weakhashmap-memory-leaks.html https://franke.ms/memoryleak1.wiki N.B. latter author filed this as a bug at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7145759 which was apparently dropped by Oracle devs as supposedly the intended behaviour for a WeakHashMap-based cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed slow memory-leak by replacing WeakHashMap with SoftHashMap<…TickMark> - based cache implementation
See the following references for details:
https://ewirch.github.io/2013/12/weakhashmap-memory-leaks.html
https://franke.ms/memoryleak1.wiki
N.B. latter author filed this as a bug at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7145759 which was apparently dropped by Oracle devs as supposedly the intended behaviour for a WeakHashMap-based cache.