Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix337 tooltip synchronization #339

Merged
merged 5 commits into from
Jan 26, 2021

Conversation

dedeibel
Copy link
Contributor

I tried to come up with a fix to #337

As suggested by Alex I tried to calculate all DataPoint information inside a read lock. One for each data set to keep it as small as possible.

…onization

Restyle Fix337 tooltip synchronization
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #339 (94feb01) into master (fc81f1f) will increase coverage by 0.02%.
The diff coverage is 94.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #339      +/-   ##
============================================
+ Coverage     51.74%   51.77%   +0.02%     
- Complexity     7300     7309       +9     
============================================
  Files           394      394              
  Lines         41197    41214      +17     
  Branches       6627     6625       -2     
============================================
+ Hits          21319    21339      +20     
  Misses        18364    18364              
+ Partials       1514     1511       -3     
Impacted Files Coverage Δ Complexity Δ
...in/java/de/gsi/chart/plugins/DataPointTooltip.java 72.22% <94.87%> (+4.33%) 31.00 <18.00> (+6.00)
...hart/plugins/measurements/DataSetMeasurements.java 75.77% <0.00%> (+0.34%) 153.00% <0.00%> (+2.00%)
...main/java/de/gsi/chart/ui/HiddenSidesPaneSkin.java 44.97% <0.00%> (+0.47%) 35.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878a4a0...94feb01. Read the comment docs.

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also like the readability improvements, thanks a lot. I'll merge this into master later today if there are no objections.

@RalphSteinhagen RalphSteinhagen merged commit 90c9a9a into master Jan 26, 2021
@RalphSteinhagen RalphSteinhagen deleted the fix337-tooltip-synchronization branch January 26, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants