-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YWatchValueIndicator: prevent occlusion of value labels #443
Conversation
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
============================================
+ Coverage 53.22% 53.25% +0.03%
- Complexity 7344 7361 +17
============================================
Files 386 386
Lines 40646 40679 +33
Branches 6544 6553 +9
============================================
+ Hits 21635 21665 +30
- Misses 17461 17462 +1
- Partials 1550 1552 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition! 👍
@raven2cz this new feature might perhaps be also of interest for your use-case?
By default, if there are multiple YWatchValueIndicators close to each other, their label texts occlude each other. This PR implements an optional flag to move the value labels on a per axis basis.
Axis on the left shows the old and now default behaviour, the Axis on the right showcases the new feature: