Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YWatchValueIndicator: prevent occlusion of value labels #443

Merged
merged 5 commits into from
Jun 29, 2021

Conversation

wirew0rm
Copy link
Member

By default, if there are multiple YWatchValueIndicators close to each other, their label texts occlude each other. This PR implements an optional flag to move the value labels on a per axis basis.

Axis on the left shows the old and now default behaviour, the Axis on the right showcases the new feature:
2021-06-29 15-23_marker_occlusion

@wirew0rm wirew0rm temporarily deployed to coverage June 29, 2021 14:39 Inactive
@wirew0rm wirew0rm temporarily deployed to coverage June 29, 2021 14:39 Inactive
@wirew0rm wirew0rm temporarily deployed to deploy June 29, 2021 14:43 Inactive
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #443 (634ed3d) into master (e684c8c) will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #443      +/-   ##
============================================
+ Coverage     53.22%   53.25%   +0.03%     
- Complexity     7344     7361      +17     
============================================
  Files           386      386              
  Lines         40646    40679      +33     
  Branches       6544     6553       +9     
============================================
+ Hits          21635    21665      +30     
- Misses        17461    17462       +1     
- Partials       1550     1552       +2     
Impacted Files Coverage Δ
...ava/de/gsi/chart/plugins/YWatchValueIndicator.java 86.27% <83.33%> (-0.69%) ⬇️
...main/java/de/gsi/chart/ui/HiddenSidesPaneSkin.java 44.49% <0.00%> (-0.48%) ⬇️
...hart/plugins/measurements/DataSetMeasurements.java 75.60% <0.00%> (+0.17%) ⬆️
.../java/de/gsi/dataset/locks/DefaultDataSetLock.java 60.21% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e684c8c...634ed3d. Read the comment docs.

@wirew0rm wirew0rm temporarily deployed to deploy June 29, 2021 14:43 Inactive
@wirew0rm wirew0rm temporarily deployed to coverage June 29, 2021 15:17 Inactive
@wirew0rm wirew0rm temporarily deployed to coverage June 29, 2021 15:17 Inactive
@wirew0rm wirew0rm temporarily deployed to coverage June 29, 2021 15:17 Inactive
@wirew0rm wirew0rm temporarily deployed to coverage June 29, 2021 15:17 Inactive
@RalphSteinhagen RalphSteinhagen self-requested a review June 29, 2021 15:20
@wirew0rm wirew0rm temporarily deployed to deploy June 29, 2021 15:21 Inactive
@wirew0rm wirew0rm temporarily deployed to deploy June 29, 2021 15:21 Inactive
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition! 👍

@raven2cz this new feature might perhaps be also of interest for your use-case?

@RalphSteinhagen RalphSteinhagen merged commit b3a4372 into master Jun 29, 2021
@RalphSteinhagen RalphSteinhagen deleted the indicatorOcclusion branch June 29, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants