added conveyor packaging for fx-sampler #580
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
============================================
- Coverage 48.06% 48.05% -0.02%
+ Complexity 6198 6197 -1
============================================
Files 374 374
Lines 38276 38278 +2
Branches 6102 6103 +1
============================================
- Hits 18398 18395 -3
- Misses 18734 18737 +3
- Partials 1144 1146 +2
☔ View full report in Codecov by Sentry. |
|
The FXSampler project has some issues w/ the Conveyor packaging format, but I managed to work around it. The packaging should be fully working now. Test release: https://files.hebi.us/internal/demo/chartfx-sampler/download.html |
|
Kudos, SonarCloud Quality Gate passed!
|
(cherry picked from commit bc18a61)
(cherry picked from commit c52c44f)
(cherry picked from commit d983471)
(cherry picked from commit e9e2f6b)
(cherry picked from commit da5bbec)
(cherry picked from commit 7ab0a11)
(cherry picked from commit 6d3ab84)
(cherry picked from commit e1c2538)
(cherry picked from commit ca0689b)
(cherry picked from commit d1cf767)
(cherry picked from commit 74ec30a)
|
SonarCloud Quality Gate failed.
|
I added a basic Conveyor configuration for the sampler app and uploaded a signed test version to chartfx-sampler. I also added a preliminary square icon to match the macOS guidelines, and fixed a few issues that broke the sampler app when running from jar files (e.g. resource paths with
.and..don't work)It probably doesn't make sense to get signing certificates for a sampler project. Maybe Hydraulic (ping @mikehearn) can handle the signing/hosting like they do for some other projects?
I'm leaving it as a draft PR for now because there is some issue with the installed versions. See conveyor#56
Update
The issue occurs when executing with
binas the working directory. Executing it manually from somewhere else works. Absolute vs relative paths do not make a difference. My best guess is that it's a bug in fx-sampler.