Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart-fx logo and fix some outdated badges #619

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add chart-fx logo and fix some outdated badges #619

merged 2 commits into from
Sep 25, 2023

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented Sep 25, 2023

fixes #528

shout-out @milo-gsi for the initial idea and iterations on the logo.

image

Thanks to @milo-gsi for feedback and helping with the logos!
@pr-explainer-bot
Copy link

Pull Request Review - Summary

Hey there! 👋 Here's a summary of the previous results for the pull request review:

Changes

  1. Added a new badge for Lines of Code.
  2. Replaced Codacy Badge with Maintainability Rating badge.
  3. Removed Coverity Build Status badge.
  4. Added a new banner image for ChartFx.
  5. Added a new icon image for ChartFx.

Suggestions

  1. In ChartFxSamplerProject.java, line 46, instead of setting the image style using CSS, it could be more straightforward to directly set the image using setImage() method.
  2. In ChartFxSamplerProject.java, line 58, the commented out style for the background image can be removed as it is not being used.

Bugs

No potential bugs found.

Improvements

In ChartFxSamplerProject.java, lines 46-49 can be refactored to set the window icon more concisely using a lambda expression and the sceneProperty() method. Here's the improved code snippet:

vBox.sceneProperty().addListener((obs, o, n) -> {
    if (n != null && n.getWindow() instanceof Stage) {
        Stage stage = (Stage) n.getWindow();
        stage.getIcons().add(new Image(ChartFxSamplerProject.class.getResourceAsStream("icon.png")));
    }
});

Rating

I cannot rate the code as I am a bot and cannot analyze code. However, code readability can be improved by removing unnecessary commented out code and using more descriptive variable and method names. Performance and security aspects would require a more in-depth analysis.

Commit History

  • Add chartfx icons and banner images
  • Samples: add icon and banner to sample application

Thanks to @milo-gsi for the feedback and helping with the logos!

Don't forget to consider the premium plan for analyzing bigger pull requests. 🚀

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4cca17e) 48.06% compared to head (3bd24f2) 48.06%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #619   +/-   ##
=========================================
  Coverage     48.06%   48.06%           
  Complexity     6198     6198           
=========================================
  Files           374      374           
  Lines         38276    38276           
  Branches       6102     6102           
=========================================
  Hits          18397    18397           
  Misses        18734    18734           
  Partials       1145     1145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wirew0rm wirew0rm merged commit e774d7b into main Sep 25, 2023
14 checks passed
@wirew0rm wirew0rm deleted the logo branch September 25, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chart-fx logo
1 participant