Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LimitedIndexedTreeDataSet: fix yErrors #653

Merged
merged 1 commit into from
Jan 30, 2024
Merged

LimitedIndexedTreeDataSet: fix yErrors #653

merged 1 commit into from
Jan 30, 2024

Conversation

wirew0rm
Copy link
Member

Fixes a small typo bug that would initialize tze yErrors with the yValues instead of the supplied yValues.

Thanks to @zanzica for finding and repoting this.

closes #652

Fixes a small typo bug that would initialize tze yErrors with the
yValues instead of the supplied yValues.

Thanks to @zanzica for finding and repoting this.
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ed86318) 48.08% compared to head (69bf7c8) 48.08%.

Files Patch % Lines
...air_acc/dataset/spi/LimitedIndexedTreeDataSet.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #653   +/-   ##
=========================================
  Coverage     48.08%   48.08%           
- Complexity     6220     6223    +3     
=========================================
  Files           374      374           
  Lines         38309    38309           
  Branches       6117     6117           
=========================================
+ Hits          18419    18421    +2     
- Misses        18732    18734    +2     
+ Partials       1158     1154    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @zanzica for spotting, and @wirew0rm for fixing this. LGTM. 👍

@RalphSteinhagen RalphSteinhagen merged commit fac84bf into main Jan 30, 2024
10 of 11 checks passed
@RalphSteinhagen RalphSteinhagen deleted the fixTreeDS branch January 30, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken handling of Y error values by multi-value LimitedIndexedTreeDataSet.set
2 participants