Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Exclude tests module from packages to build. #47

Merged
merged 1 commit into from
Jun 3, 2020
Merged

[FIX] Exclude tests module from packages to build. #47

merged 1 commit into from
Jun 3, 2020

Conversation

mathdugre
Copy link
Contributor

This change is to fix #46.

@NickolausDS
Copy link
Collaborator

Thanks for the PR!

Since this package uses MANIFEST.in, it might be better to specify excludes there. Something like:

prune tests
prune examples
global-exclude .*

@mathdugre
Copy link
Contributor Author

I'm not so familiar with the packaging procedure.
Should it only be included in MANIFEST.in? Or in both setup.py and MANIFEST.in?

@NickolausDS
Copy link
Collaborator

It would be best if it was only a single location. I'm not too familiar with the differences between passing args through find_packages() vs using a MANIFEST.in file, but the latter has worked pretty well and I would prefer to continue using it unless we have a good reason to switch.

@mathdugre
Copy link
Contributor Author

Hi @NickolausDS , I made the requested changes. If there is nothing else, I think this would be ready to be merged.

@NickolausDS NickolausDS merged commit 2f70f75 into fair-research:develop Jun 3, 2020
@NickolausDS
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude tests from packages list in setup.py
2 participants