Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch id (#121) #122

Merged
merged 2 commits into from
Mar 20, 2023
Merged

fix: batch id (#121) #122

merged 2 commits into from
Mar 20, 2023

Conversation

tomicvladan
Copy link
Collaborator

If batch ID can't be fetched, sets it to '0'. That enables the user to use a gateway instead of a local node.

Copy link
Collaborator

@nugaon nugaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it

src/utils/bee.ts Outdated
} catch (error) {
console.warn(String(error))

return '0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to return 64 '0's instead.

@tomicvladan tomicvladan requested a review from nugaon March 20, 2023 11:30
Copy link
Collaborator

@nugaon nugaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomicvladan tomicvladan merged commit 84dbf06 into master Mar 20, 2023
@tomicvladan tomicvladan deleted the fix/batch-id branch March 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants