Feat/wallet #156
Merged
Feat/wallet #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorShadurin
requested changes
Aug 25, 2023
There was a problem hiding this comment.
- Try to enter simple eth address instead of smart contract address during token import. You can see error:
Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="name()", data="0x", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.7.0)
Would be great to show something user-friendly
- Try to send more ETH than available, it will show also user unfriendly error.
assets/locales/en-US.json
Outdated
| "SELECT": "Select", | ||
| "SELECT_ADDRESS": "Choose address to send to", | ||
| "PROCEED": "Proceed", | ||
| "SENDING_TO": "Sednding to", |
There was a problem hiding this comment.
"Sending to" instead of "Sednding to"
|
@IgorShadurin Changes are made in this PR. I separated wallet fixes there because the PRs are already too large. |
tfius
approved these changes
Aug 28, 2023
* feat: wallet improvements * feat: wallet improvements * fix: wallet lock options * fix: wallet lock mechanism * feat: fetching account info * feat: improve error messages ui
* feat: new swarm settings * feat: configurable bee url (#157) * chore: update readme * chore: fix typo
IgorShadurin
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning the Blossom extension into a wallet.
New features: