Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/localization #437

Merged
merged 19 commits into from Aug 10, 2023
Merged

Feat/localization #437

merged 19 commits into from Aug 10, 2023

Conversation

tomicvladan
Copy link
Collaborator

Added support for other languages.

Closes #418

Copy link
Collaborator

@tfius tfius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ai translations - maybe we need to say somewhere that translations were made by AI ?

@tomicvladan
Copy link
Collaborator Author

@tfius That's a good idea. Maybe we could add a tooltip to the dropdown?

Copy link
Collaborator

@IgorShadurin IgorShadurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. On the mobile version, the header breaks due to the new button.
Screenshot 2023-08-09 at 18 58 11
  1. "Your passphrase is used for the encryption and decryption of your data. Do not share it."
    has not been translated.

  2. I tried Russian. There are some phrases that should be changed. Some phrases are not translated.
    Since the font does not support Cyrillic, the Russian language looks bad. I propose to leave the Russian language as a separate task, as it requires additional labor.

Screenshot 2023-08-09 at 19 04 58 Screenshot 2023-08-09 at 19 05 33

ru-RU.json.zip

  1. In rs-RS there are phrases containing Cyrillic. It will also not display very well. "ENTER_PASSPHRASE": "Унесите приступну фразу",

@tomicvladan
Copy link
Collaborator Author

@IgorShadurin

  1. I noticed that but don't know how to fix it. There is no enough space to fit all elements on some tablet screens.
  2. Fixed
  3. It's strange that it doesn't support Cyrillic. Maybe something else is a problem?
  4. Fixed

@tomicvladan
Copy link
Collaborator Author

I think now looks good. I had to remove label for "Import account" button on mobile screens.
Screenshot from 2023-08-10 10-32-29

@tfius tfius merged commit cb5c331 into development Aug 10, 2023
2 checks passed
@tfius tfius deleted the feat/localization branch August 10, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants