Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/UI improvements #524

Merged
merged 6 commits into from Sep 27, 2023
Merged

Feat/UI improvements #524

merged 6 commits into from Sep 27, 2023

Conversation

tomicvladan
Copy link
Collaborator

Added additional descriptions to the Metamask passphrase modal and the main invites page.

Copy link
Collaborator

@IgorShadurin IgorShadurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-25 at 15 30 19

pwd_localhost_3000_

I like the idea of explaining to the user what the password is for.
However, it seems to me that this explanation should only be shown if the user wants it. This will help simplify the interface.

An example of how this can be done through tooltip or popovers

Screenshot 2023-09-25 at 15 20 47 Screenshot 2023-09-25 at 15 21 25

wdyt?

@tomicvladan
Copy link
Collaborator Author

I agree, using a tooltip would improve UI, but most likely users won't even read the message in such situation. This information is important to be aware of, and keeping it visible it will increase chances that users will actually read it.

@tfius
Copy link
Collaborator

tfius commented Sep 25, 2023

this is very ugly, bad ux, how can we change it ?
it might be better that text explaining procedure is "after" command button.

@tomicvladan
Copy link
Collaborator Author

Maybe this additional text can be moved to a component like this https://headlessui.com/react/disclosure

@tfius
Copy link
Collaborator

tfius commented Sep 27, 2023

Maybe this additional text can be moved to a component like this https://headlessui.com/react/disclosure

could be

@tomicvladan
Copy link
Collaborator Author

This is the latest change that I made.

When opening this modal for the first time (first time login with Metamask), the message is expanded so the user will be able to see the message:

Screenshot from 2023-09-27 12-59-09

Each next time when the user opens this modal again, the message will be hidden, but it can be opened by clicking the "Read more" section.

Screenshot from 2023-09-27 12-59-14

@tfius tfius merged commit ece84dc into development Sep 27, 2023
1 of 2 checks passed
@tfius tfius deleted the feat/ui-improvements branch September 27, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants