-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add dashboard question to FAQ and how to save a plot #768 #1021
DOC: Add dashboard question to FAQ and how to save a plot #768 #1021
Conversation
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
…enbach/fairlearn into faq_fairlearn_dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Thanks for this. I added just one small comment.
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. Ideally, you could put a screenshot from the generated docs (only the part you changed, of course) to give reviewers an idea of what it looks like after your change is applied 🙂 In the new PR template that's sort of suggested with a "Screenshots" section but your PR preceeds that I think, so no worries.
@rensoostenbach can you post a screenshot of the resulting website? |
|
Love it! Can one of @fairlearn/fairlearn-maintainers take a look? I approved already so feel free to merge if you are fine with the PR as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
not sure why "Squash and merge" is disabled for me, will wait for the CI to see what happens next. |
This PR addresses the two TODO's in #768:
I am unsure if https://fairlearn.org/main/user_guide/assessment.html#fairlearn-dashboard should be completely removed from the assessment page, since the first paragraph of the assessment page still links to it. Perhaps the :ref:'dashboard' should be changed to :ref:'plot'? (intentionally using the wrong quotes here)