-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Add SciPy tutorial dataset to fairlearn.datasets #1086
ENH Add SciPy tutorial dataset to fairlearn.datasets #1086
Conversation
I still need to write the User Guide for this PR, I will start next week with that.
That line and the surrounding lines are done in the same way as in the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments!
Tagging @LeJit and @MiroDudik who may have thoughts on what (else) should be in the user guide. |
Co-authored-by: Hilde Weerts <24417440+hildeweerts@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1086 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 51
Lines ? 2180
Branches ? 0
======================================
Hits ? 0
Misses ? 2180
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
It may be worthing including a link to the full |
It is actually there already in line 35 of |
@rensoostenbach I was thinking more about referencing it in the docstring of |
Merged with the latest |
🤦🏼 OpenML's SSL certificate is expired, they're working on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is ready to get merged!
This PR adds the SciPy tutorial dataset to fairlearn.datasets, as discussed in #1066
Completing this item requires:
Description
I have implemented the fetch function as fairlearn.datasets.fetch_diabetes_hospital, but ofcourse it would be easy to rename it to something else if prefered. I wasn't sure how detailed the User Guide should be, and also what parts should be included in the user guide. If there is anything that would be valuable to include that isn't in there yet, I would be happy to write that as well.
Tests
Documentation
Screenshots