Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT add pyarrow dependency #1335

Merged
merged 1 commit into from Jan 23, 2024
Merged

MNT add pyarrow dependency #1335

merged 1 commit into from Jan 23, 2024

Conversation

adrinjalali
Copy link
Member

Fixes #1334

Signed-off-by: adrinjalali <adrin.jalali@gmail.com>
@hildeweerts
Copy link
Contributor

hildeweerts commented Jan 23, 2024

It does look like they're still gathering feedback before the pyarrow dependency becomes final (but perhaps the actual decision has already been taken?).

I haven't read the entire thread but a couple of comments stood out to me. One major thing to consider is that the pyarrow build is pretty big:

Including PyArrow would naturally increase the installation size of pandas. For example, installing pandas and PyArrow using pip from wheels, numpy and pandas requires about 70MB, and including PyArrow requires an additional 120MB. An increase of installation size would have negative implication using pandas in space-constrained development or deployment environments such as AWS Lambda.

And this one.

Also, if PyArrow is truly going to be a required required dependency in Pandas 3.0, then I don't see the point of the current DeprecationWarning in pandas 2.2.0. All sane package python managers install required dependencies automatically, so users don't need to take any action anyway.

@adrinjalali
Copy link
Member Author

Yes, they have already voted and made the decision. I've been watching this for quite some time now. It's happening. My recommendation to people is simply to switch to polars.

@hildeweerts hildeweerts merged commit 369c2a1 into fairlearn:main Jan 23, 2024
19 of 33 checks passed
@adrinjalali
Copy link
Member Author

oh, I was gonna fix other issues, I'll open a new PR for them then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNT Deprecation warning Pyarrow
3 participants