-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-v0.6.2 release adjustments #775
Post-v0.6.2 release adjustments #775
Conversation
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
This reverts commit 9e07dd2.
I should have been clearer about this, but these sorts of PRs should only be completed after the release is complete. FYI @fairlearn/fairlearn-maintainers |
@romanlutz could you explain a bit more why this PR shouldn't have been completed? I want to make sure I don't break stuff in the future :D |
@hildeweerts great question! I've tried to explain a bit further in the new release instructions in #794 . The TL;DR is that merging any PR triggers a new doc build that pushes the built webpage to the webpage repo fairlearn/fairlearn.github.io . That's intentional, of course! However, the versioned doc build only picks up already released versions. So by increasing the version in the links of our index.html we effectively pointed to pages that couldn't exist yet since the release wasn't out. Instead, we need to release to pypi first, tag the release, then merge the post-v<x.y.z> adjustments (like this PR) which triggers the build and generates the new webpage including the pages for v<x.y.z>. Does that make sense? |
Thanks for the explanation @romanlutz! That makes a lot of sense (I can't promise that I will never mistakingly merge something in the future though, lol) |
Other than the adjustments in #774 this puts the version to
0.7.0.dev0
and adds the missing release instructions.I expect the next release will require a new minor version since I have #766 out which should be completed shortly. We can certainly change that if this assumption turns out to be wrong, though.