More small factory refactorings

fairmondo · Oct 26, 2015 · df9bd87 · df9bd87
1 parent 055b5ab
commit df9bd87
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/test/factories/articles.rb b/test/factories/articles.rb
@@ -28,9 +28,6 @@
       end
     end
 
-    basic_price_cents 50000
-    basic_price_amount :kilogram
-
     before :create do |article, _evaluator|
       article.calculate_fees_and_donations
     end
@@ -39,8 +36,8 @@
     transport_type1_provider 'DHL Päckchen'
     transport_type1_price_cents 400
     transport_details 'transport_details'
-    payment_bank_transfer true
 
+    payment_bank_transfer true
     payment_details 'payment_details'
 
     factory :article_template do

diff --git a/test/factories/business_transactions.rb b/test/factories/business_transactions.rb
@@ -20,8 +20,8 @@
     end
     line_item_group { FactoryGirl.create :line_item_group, :sold, seller: seller, buyer: buyer }
 
-    selected_transport 'type1'
-    selected_payment 'bank_transfer'
+    selected_transport :type1
+    selected_payment :bank_transfer
     sold_at { Time.now }
     discount_value_cents 0
     quantity_bought 1
@@ -87,27 +87,27 @@
     end
 
     trait :cash do
-      selected_payment 'cash'
+      selected_payment :cash
     end
 
     trait :paypal do
-      selected_payment 'paypal'
+      selected_payment :paypal
     end
 
     trait :invoice do
-      selected_payment 'invoice'
+      selected_payment :invoice
     end
 
     trait :cash_on_delivery do
       selected_payment :cash_on_delivery
     end
 
     trait :bank_transfer do
-      selected_payment 'bank_transfer'
+      selected_payment :bank_transfer
     end
 
     trait :voucher do
-      selected_payment 'voucher'
+      selected_payment :voucher
     end
   end
 end